[WIP; depends on #232] Metropolis: EIP211 Returndata instructions #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirapira
commented
Mar 21, 2017
| @@ -851,7 +851,8 @@ \subsection{Execution Overview} | |||
| \boldsymbol{\mu}_{pc} & \equiv & 0 \\ | |||
| \boldsymbol{\mu}_\mathbf{m} & \equiv & (0, 0, ...) \\ | |||
| \boldsymbol{\mu}_i & \equiv & 0 \\ | |||
| \boldsymbol{\mu}_\mathbf{s} & \equiv & () | |||
| \boldsymbol{\mu}_\mathbf{s} & \equiv & () \\ | |||
| \boldsymbol{\mu}_\mathbf{o} & \equiv & () | |||
There was a problem hiding this comment.
For clarification, here is the initialization of μₒ.
pirapira
commented
Mar 21, 2017
| @@ -1965,6 +1976,7 @@ \subsection{Instruction Set} | |||
| &&&& $(\boldsymbol{\sigma}', g', A^+, \mathbf{o}) \equiv \begin{cases}\begin{array}{l}\Theta(\boldsymbol{\sigma}, I_a, I_o, t, t,\\ \quad C_{\text{\tiny CALLGAS}}(\boldsymbol{\mu}), I_p, \boldsymbol{\mu}_\mathbf{s}[2], \boldsymbol{\mu}_\mathbf{s}[2], \mathbf{i}, I_e + 1)\end{array} & \begin{array}{l}\text{if} \quad \boldsymbol{\mu}_\mathbf{s}[2] \leqslant \boldsymbol{\sigma}[I_a]_b \;\wedge \\ \quad\quad I_e < 1024\end{array}\\ (\boldsymbol{\sigma}, g, \varnothing, ()) & \text{otherwise} \end{cases}$ \\ | |||
| &&&& $n \equiv \min(\{ \boldsymbol{\mu}_\mathbf{s}[6], |\mathbf{o}|\})$ \\ | |||
| &&&& $\boldsymbol{\mu}'_\mathbf{m}[ \boldsymbol{\mu}_\mathbf{s}[5] \dots (\boldsymbol{\mu}_\mathbf{s}[5] + n - 1) ] = \mathbf{o}[0 \dots (n - 1)]$ \\ | |||
| &&&& $\boldsymbol{\mu}'_\mathbf{o} = \mathbf{o}$ \\ | |||
There was a problem hiding this comment.
... and here is the update of μₒ.
This change is according to ethereum/EIPs#211 (comment)
This was referenced Mar 22, 2017
Closed
pirapira
changed the title
pirapira
commented
May 9, 2017
| @@ -1958,13 +1969,15 @@ \subsection{Instruction Set} | |||
| &&&& low to fulfil the value transfer); and otherwise $x=A(I_a, \boldsymbol{\sigma}[I_a]_n)$, the address of the newly \\ | |||
| &&&& created account, otherwise. \\ | |||
| &&&& $\boldsymbol{\mu}'_i \equiv M(\boldsymbol{\mu}_i, \boldsymbol{\mu}_\mathbf{s}[1], \boldsymbol{\mu}_\mathbf{s}[2])$ \\ | |||
| &&&& $\boldsymbol{\mu}'_\mathbf{o} \equiv ()$ \\ | |||
There was a problem hiding this comment.
When the execution ends in REVERT, the output data might be non-empty.
There was a problem hiding this comment.
- The returning data of CREATE can be added after EIP140: REVERT #232 .
pirapira
changed the title
pirapira
changed the title
even when the accessed length is zero.
|
This target should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Metropolis changes, this PR adds RETURNDATACOPY and RETURNDATASIZE instructions.
Fixes #233