Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECIP 1103: Magneto EVM and Protocol Upgrades #412

Closed
q9f opened this issue Feb 9, 2021 · 8 comments · Fixed by #430
Closed

ECIP 1103: Magneto EVM and Protocol Upgrades #412

q9f opened this issue Feb 9, 2021 · 8 comments · Fixed by #430
Labels
status:1 draft ECIP is in draft stage an can be assigned ECIP number and merged, but requires community consensus. type: std-core ECIPs of the type "Core" - changing the Classic protocol.

Comments

@q9f
Copy link
Contributor

q9f commented Feb 9, 2021

ref #411

Enable the outstanding Ethereum Foundation Berlin network protocol upgrades on
the Ethereum Classic network in a hard-fork code-named Magneto to enable
maximum compatibility across these networks.
@q9f q9f added type: std-core ECIPs of the type "Core" - changing the Classic protocol. status:1 draft ECIP is in draft stage an can be assigned ECIP number and merged, but requires community consensus. labels Feb 9, 2021
@stevanlohja
Copy link
Contributor

stevanlohja commented Feb 10, 2021 •
edited
Loading

Is the proposal substantiated with a roadmap and strategy pertaining to ETC other than merging ETH updates?

@gitr0n1n
Copy link
Contributor

gitr0n1n commented Feb 13, 2021 •
edited
Loading

The proposal needs to be substantiated with a roadmap and strategy pertaining to ETC other than merging ETH changes.

I haven't seen that as a requirement for submitting an ECIP. Please cite in the ECIP-1000 where it mentions this requirement. Thanks!

Also, I don't see this ECIP as out of left field. I believe protocol parity remains a roadmap goal of ETC, unless @stevanlohja has some new information to share with the network participants. The Berlin updates continue the goals of the established path to keep ETC and ETH interoperable. The specific EIPs should definitely be anaylzed and debated, but this proposal itself does not appear out of line.

@q9f
Copy link
Contributor Author

q9f commented Feb 15, 2021

I'm happy to collaborate on a roadmap if anyone wants to champion this. Not really relevant for this proposal though. Having the protocol updated to the latest version is the least we can do unless we want to developers to use xDAI or Binance Chain instead.

@slavserver
Copy link

won't you all calm down? ))

@meowsbits
Copy link
Member

meowsbits commented Mar 15, 2021 •
edited
Loading

  • Parity. In order for this proposal to match the Berlin Network Upgrade Specification it (now) needs to remove EIP-2315.

  • Timelines. I assume that the block numbers in the spec are intended tentatively. Ethereum is aiming for an ETH mainnet activation at 12_244_000 (14 Apr 2021), and this spec proposes "May 2021" for ETC mainnet activation. For the sake of conservative risk management I propose targeting a minimum of 45-60 days behind the intended ETH activation.

@meowsbits
Copy link
Member

meowsbits commented Apr 1, 2021 •
edited
Loading

We have some cross-client tests generated including subtests for the Magneto configuration.
I have them as a WIP PR here: etclabscore/tests#4. Still under development and review, so don't treat them as a concrete reference just yet, but should be good for starters. Development versions of CoreGeth pass all incumbent and generated tests (for Berlin, Magneto, and all preceding and test fork configurations).

Generated/filled tests are extrapolated from the standard https://github.com/ethereum/tests suite, with CoreGeth filling additional tests for Ethereum Classic fork configurations using Ethereum-canonical fork configurations as reference for Pre-State and Transaction parameters (in the case of the GeneralStateTests).

Test generation has been done on top of the latest version pegged by ethereum/go-ethereum v1.10.1 at https://github.com/ethereum/tests/tree/c600d7795aa2ea57a9c856fc79f72fc05b542124.

q9f added a commit that referenced this issue May 10, 2021
@q9f
1103: propose timeline
abf253a 
ref #412 #424
@q9f q9f mentioned this issue May 10, 2021
Merged
q9f added a commit that referenced this issue May 25, 2021
@q9f
ECIP 1103: propose timeline (#425)
faf7897 
* 1103: propose timeline

ref #412 #424

* update block numbers

* move to last call
@drospa
Copy link

drospa commented Jun 1, 2021

@q9f can you also add that Mantis (maintained by IOHK) will support this HF but at a later state than the proposed 13_189_133 on ETC PoW-mainnet (July 21st, 2021)?

meowsbits added a commit that referenced this issue Jun 1, 2021
@meowsbits
add client status
daa06c0 
Rel #412 (comment)
@meowsbits meowsbits mentioned this issue Jun 1, 2021
Merged
q9f pushed a commit that referenced this issue Jun 4, 2021
@meowsbits
add client status (#427)
291893f 
Rel #412 (comment)
@q9f q9f mentioned this issue Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:1 draft ECIP is in draft stage an can be assigned ECIP number and merged, but requires community consensus. type: std-core ECIPs of the type "Core" - changing the Classic protocol.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move 1103 to final (mainnet) ethereumclassic/ECIPs
7 participants
@stevanlohja @slavserver @meowsbits @gitr0n1n @q9f @drospa and others