Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update ecip editors, withdraw inactive ecips #454

Merged
merged 5 commits into from
Dec 22, 2021
Merged

fix: update ecip editors, withdraw inactive ecips #454

merged 5 commits into from
Dec 22, 2021

Conversation

stevanlohja
Copy link
Contributor

@gitr0n1n
Copy link
Contributor

gitr0n1n commented Dec 18, 2021 •
edited
Loading

Where are you sourcing the Editors list for review @stevanlohja ?

Oh i see: #448

Will this list be updated? https://github.com/ethereumclassic/ECIPs/blob/master/_specs/ecip-1000.md

gitr0n1n
gitr0n1n suggested changes Dec 18, 2021
View reviewed changes
Copy link
Contributor

@gitr0n1n gitr0n1n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looks like this is editing a withdrawn ECIP-0001. The active document is ECIP-1000

Can you shuffle the inactive ECIP editors to the inactive list, opposed to removing them as displayed on ECIP-1000

https://github.com/ethereumclassic/ECIPs/blob/master/_specs/ecip-1000.md

@stevanlohja
Copy link
Contributor Author

I looks like this is editing a withdrawn ECIP-0001. The active document is ECIP-1000

Can you shuffle the inactive ECIP editors to the inactive list, opposed to removing them as displayed on ECIP-1000

https://github.com/ethereumclassic/ECIPs/blob/master/_specs/ecip-1000.md

Yes. Now check latest commit.

gitr0n1n
gitr0n1n approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@gitr0n1n gitr0n1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gitr0n1n gitr0n1n merged commit 0931e6a into ethereumclassic:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitr0n1n gitr0n1n gitr0n1n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new editors, set 1092/94/96 to inactive
2 participants
@stevanlohja @gitr0n1n