Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Added support for setting network, hardfork-specific validation, putHeader()/putHeaders() functions #59

Merged
merged 3 commits into from
Aug 9, 2018

Conversation

vpulim
Copy link
Contributor

@vpulim vpulim commented Jul 28, 2018

  • Added support for setting network and performing hardfork-specific validation by integrating with ethereumjs-common
  • Added putHeader() and putHeaders() functions to provide header-chain functionality needed by ethereumjs-client
  • Fixed a bug with caching

Addresses #54. These changes are needed by ethereumjs-client (and also for block 2.x support in ethereumjs-vm)

@vpulim vpulim requested a review from holgerd77 July 28, 2018 15:25
@coveralls
Copy link

coveralls commented Jul 28, 2018

Coverage Status

Coverage increased (+1.09%) to 97.93% when pulling fce8723 on vpulim:header-chain into 96b4f36 on ethereumjs:master.

@vpulim vpulim force-pushed the header-chain branch 3 times, most recently from a0b5427 to 6de84b9 Compare July 30, 2018 21:47
@vpulim vpulim changed the title [DO NOT MERGE] Added support for setting network, hardfork-specific validation, putHeader()/putHeaders() functions Added support for setting network, hardfork-specific validation, putHeader()/putHeaders() functions Jul 30, 2018
@vpulim vpulim force-pushed the header-chain branch 2 times, most recently from 2e1671d to 3fc3320 Compare August 8, 2018 11:18
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, had a look over all the code changes.

@holgerd77
Copy link
Member

Please forgive me, I wanted to see how much of this I could directly do with iPad and GitHub web editor functionality and somewhat bloated the commit history along the way. Feel free to undo/reorg, I will reapprove asap in case.

@vpulim
Copy link
Contributor Author

vpulim commented Aug 9, 2018

@holgerd77 no problem, and thanks for the review. I rebased on top of master.

@holgerd77
Copy link
Member

Ok, feel free to merge

@vpulim vpulim merged commit 7ce7b80 into ethereumjs:master Aug 9, 2018
@holgerd77
Copy link
Member

You'll probably also need this as a release once this is merged, don't you? Would then release as v3.2.0, does this make sense?

@vpulim
Copy link
Contributor Author

vpulim commented Aug 9, 2018

Yes, a new release would be ideal for ethereumjs-client work. 3.2.0 makes sense

@vpulim vpulim deleted the header-chain branch August 12, 2018 07:52
@holgerd77
Copy link
Member

Ok, released this as v3.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants