This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Added support for setting network, hardfork-specific validation, putHeader()/putHeaders() functions #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpulim
force-pushed
the
header-chain
branch
3 times, most recently
from
July 30, 2018 21:47
a0b5427
to
6de84b9
Compare
vpulim
changed the title
[DO NOT MERGE] Added support for setting network, hardfork-specific validation, putHeader()/putHeaders() functions
Added support for setting network, hardfork-specific validation, putHeader()/putHeaders() functions
Jul 30, 2018
This was referenced Jul 30, 2018
vpulim
force-pushed
the
header-chain
branch
2 times, most recently
from
August 8, 2018 11:18
2e1671d
to
3fc3320
Compare
holgerd77
approved these changes
Aug 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, had a look over all the code changes.
Please forgive me, I wanted to see how much of this I could directly do with iPad and GitHub web editor functionality and somewhat bloated the commit history along the way. Feel free to undo/reorg, I will reapprove asap in case. |
@holgerd77 no problem, and thanks for the review. I rebased on top of master. |
Ok, feel free to merge |
You'll probably also need this as a release once this is merged, don't you? Would then release as |
Yes, a new release would be ideal for ethereumjs-client work. 3.2.0 makes sense |
Ok, released this as v3.2.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #54. These changes are needed by
ethereumjs-client
(and also for block 2.x support inethereumjs-vm
)