This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Iterator should return without errors if no more blocks #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagating errors in
iterator
has caused an issue that I unfortunately hadn't foreseen. I'm sorry about this.It tries to get the next blocks, and when the next block doesn't exist, it returns the
NotFoundError
upstream, which shouldn't be the case. I tried to fix this with minimal change , however please let me know if you want it fixed in another way.Furthermore the PR modifies the test case checking for iterating an empty blockchain to check for errors in callback.