This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some db ops to DBManager #91
Move some db ops to DBManager #91
Changes from all commits
5670e7e
3c75ba4
20b3b4d
eb74e99
2caf828
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add JSDoc comments to the publicly exposed functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(hmm, second thought: or maybe we'll leave it until integrating auto-generated documentation, up to you)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will try to add a bit at least for now. This made me think, should all these methods be public or private? On
Blockchain
it makes sense to have them as private, but they're the core functionality ofDBManager
🤔 What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I am also getting unsure on various fronts. Wasn't getting aware that
DBManager
isn't really prepared to go into the public space (right?). Are all publicly documented API methods from the README still kept in the mainBlockchain
class?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't go public by default, when users do
const Blockchain = require('ethereumjs-blockchain')
they'd get theBlockchain
class, and they'd have to explicitly importDBManager
to get access to these methods. Should be fine.Yeah, the API hasn't changed and the methods in
Blockchain
only act as a wrapper for methods inDBManager
.