monorepo: reset ethereum-tests to develop

tx: move api test to legacy test tx: lint
ethereumjs · Mar 2, 2021 · 9c6f2f6 · 9c6f2f6
1 parent be27b71
commit 9c6f2f6
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 10 deletions.
diff --git a/.gitmodules b/.gitmodules
@@ -1,4 +1,4 @@
 [submodule "ethereum-tests"]
 	path = packages/ethereum-tests
 	url = https://github.com/qbzzt/tests.git
-	branch = eip2930
+	branch = develop
diff --git a/packages/tx/src/legacyTransaction.ts b/packages/tx/src/legacyTransaction.ts
@@ -7,13 +7,10 @@ import {
   bnToHex,
   bnToRlp,
   ecrecover,
-  ecsign,
   rlp,
   rlphash,
   toBuffer,
   unpadBuffer,
-  publicToAddress,
-  MAX_INTEGER,
 } from 'ethereumjs-util'
 import { TxOptions, TxData, JsonTx } from './types'
 import { BaseTransaction } from './baseTransaction'

diff --git a/packages/tx/src/transactionFactory.ts b/packages/tx/src/transactionFactory.ts
@@ -106,7 +106,6 @@ export default class TransactionFactory {
       default:
         throw new Error(`TypedTransaction with ID ${transactionID} unknown`)
     }
-    throw new Error(`TypedTransaction with ID ${transactionID} unknown`)
   }
 
   /**

diff --git a/packages/tx/test/api.spec.ts → packages/tx/test/legacy.spec.ts b/packages/tx/test/api.spec.ts → packages/tx/test/legacy.spec.ts
diff --git a/packages/tx/test/transactionFactory.spec.ts b/packages/tx/test/transactionFactory.spec.ts
@@ -1,11 +1,7 @@
 import Common from '@ethereumjs/common'
 import { BN } from 'ethereumjs-util'
 import tape from 'tape'
-import {
-  EIP2930Transaction,
-  TransactionFactory,
-  LegacyTransaction
-} from '../src'
+import { EIP2930Transaction, TransactionFactory, LegacyTransaction } from '../src'
 
 const EIP2930Common = new Common({
   eips: [2718, 2929, 2930],
-Original file line number
+Diff line change
@@ Expand Up / @@ -106,7 +106,6 @@ export default class TransactionFactory { @@
           default:
             throw new Error(`TypedTransaction with ID ${transactionID} unknown`)
         }
-        throw new Error(`TypedTransaction with ID ${transactionID} unknown`)
       }
       /**
@@ Expand Down @@