Client Network Improvements #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng instead of disconnect number)
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
force-pushed
the
client-network-improvements
branch
from
da63b69
to
37e1721
Compare
| @@ -208,7 +208,7 @@ export class ETH extends EventEmitter { | |||
| this._latestBlock = status.latestBlock | |||
| } | |||
| const forkHashB = Buffer.from(this._forkHash.substr(2), 'hex') | |||
| const nextForkB = Buffer.from(this._nextForkBlock.toString(16), 'hex') | |||
| const nextForkB = int2buffer(this._nextForkBlock) | |||
There was a problem hiding this comment.
I don't really see how this is a fix to a bug? What is changed here?
There was a problem hiding this comment.
I am just a simple man and still not so fluent in Buffer operations after all these years 😜 . The only thing I can say here is that the old code delivered an empty Buffer, just re-tested this with Node to be sure:
> let nextForkBlock = 5
undefined
> Buffer.from(nextForkBlock.toString(16), 'hex')
<Buffer >
There was a problem hiding this comment.
ha! here is some explanation: nodejs/node#24491 (comment)
|
@alcuadrado @ryanio this is a good PR example where |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
nextForkBlockcorrectly on ETH.sendStatus() msg