Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: additional coverage #1261

Merged
merged 4 commits into from
May 20, 2021
Merged

tests: additional coverage #1261

merged 4 commits into from
May 20, 2021

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented May 20, 2021

This PR adds coverage for missed lines of code, mostly gathered from codecov check warnings from #1148.

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #1261 (c858e57) into master (a03be0f) will decrease coverage by 1.40%.
The diff coverage is 100.00%.

Impacted file tree graph

Flag Coverage Δ
block 86.20% <100.00%> (+4.00%) ⬆️
blockchain 84.42% <ø> (ø)
client 84.82% <ø> (+0.28%) ⬆️
common 88.61% <ø> (+0.49%) ⬆️
devp2p 84.07% <ø> (+0.46%) ⬆️
ethash 82.08% <ø> (ø)
tx 89.06% <ø> (+0.44%) ⬆️
vm 81.05% <ø> (-5.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

holgerd77 commented May 20, 2021

Ah, when seeing this cliqueBeneficiary test: this is one of the last open questions at least I have if it would make sense to generalize this option and not limit to PoA, see this comment.

Would be a pity if we miss this opportunity and introduce half-thought-through new options which are hard to revert or change later on.

@ryanio maybe you have also got an opinion on this, or @jochem-brouwer might also want to express some final thoughts here since there were still some open questions before.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good, really nice test additions! 😀

})

tape(`${method}: call with no peers`, (t) => {
const client = createClient({ noPeers: true })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I actually didn't know how to test this. 😄

@holgerd77 holgerd77 merged commit f1d7ddb into master May 20, 2021
@holgerd77 holgerd77 deleted the additional-coverage branch May 20, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants