-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: additional coverage #1261
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Ah, when seeing this Would be a pity if we miss this opportunity and introduce half-thought-through new options which are hard to revert or change later on. @ryanio maybe you have also got an opinion on this, or @jochem-brouwer might also want to express some final thoughts here since there were still some open questions before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good, really nice test additions! 😀
}) | ||
|
||
tape(`${method}: call with no peers`, (t) => { | ||
const client = createClient({ noPeers: true }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I actually didn't know how to test this. 😄
This PR adds coverage for missed lines of code, mostly gathered from codecov check warnings from #1148.