Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate util/object #1809

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Deprecate util/object #1809

merged 1 commit into from
Mar 23, 2022

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Mar 23, 2022

This cherrypicks and squashes the relevant commits from #1767 and rebased on current develop.

@ScottyPoi, did I miss any of your commits in this one? Otherwise, should be ready for review now that #1771 is merged.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1809 (ea96aee) into develop (b768b78) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 85.17% <ø> (ø)
blockchain 83.60% <ø> (ø)
client 76.61% <ø> (ø)
common 94.61% <ø> (ø)
devp2p 82.90% <ø> (-0.14%) ⬇️
ethash 90.71% <ø> (ø)
trie 86.53% <ø> (ø)
tx 94.49% <ø> (ø)
util 89.45% <ø> (-0.10%) ⬇️
vm 81.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

Thanks for the reorganization work 🙏. There are two more commits to be cherry-picked here, see https://github.com/ethereumjs/ethereumjs-monorepo/pull/1767/commits.

@acolytec3
Copy link
Contributor Author

Thanks for the reorganization work pray. There are two more commits to be cherry-picked here, see https://github.com/ethereumjs/ethereumjs-monorepo/pull/1767/commits.

The changes should all be there. Without thinking, I squashed the three of them down to one but the diff is the same for both against develop (pending confirmation from @ScottyPoi).

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, great, LGTM.

@holgerd77 holgerd77 merged commit 3e981f1 into develop Mar 23, 2022
@holgerd77 holgerd77 deleted the util-dep-tasks-2 branch March 23, 2022 17:15
holgerd77 pushed a commit that referenced this pull request Mar 24, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
@ryanio ryanio mentioned this pull request Mar 24, 2022
51 tasks
holgerd77 pushed a commit that referenced this pull request Apr 5, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
holgerd77 pushed a commit that referenced this pull request Apr 7, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
g11tech pushed a commit that referenced this pull request Apr 29, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
holgerd77 pushed a commit that referenced this pull request May 4, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
g11tech pushed a commit that referenced this pull request Jun 2, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
g11tech pushed a commit that referenced this pull request Jun 2, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
g11tech pushed a commit that referenced this pull request Jun 2, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
g11tech pushed a commit that referenced this pull request Jun 3, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
holgerd77 pushed a commit that referenced this pull request Jun 8, 2022
Co-authored-by: ScottyPoi <scott.simpson@ethereum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants