EVM/VM refactor #1892
Merged
EVM/VM refactor #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…supported HFs to EVM
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabrocheleau
force-pushed
the
evm-vm-refactor-final
branch
from
b99a766 to
afac4b3
Compare
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
ryanio
reviewed
May 18, 2022
|
overall looks great, really nice refactoring, thanks for sticking through with this massive PR @gabrocheleau! just a few last nits then all good from me! some more review from holger and jochem would be great |
holgerd77
reviewed
May 18, 2022
packages/vm/src/evm/evm.ts
Outdated
| /** | ||
| * A {@link StateManager} instance to use as the state store | ||
| */ | ||
| stateManager: StateManager |
There was a problem hiding this comment.
Just a note: this should rather be an in-between-step, after the EEI extraction (where external things like state access is encapsulated), a state manager dependency in the EVM itself should not be necessary any more.
There was a problem hiding this comment.
Yes, good point. In general I think that VM will instantiate EEI, StateManager and EVM. EEI will have a EVM dependency since EVM will introduce the EEI interface. EEI will depend upon StateManager - here StateManager is also used to export the interface. In "default" mode, VM instantiates EEI(StateManager) and EVM(EEI). EEI will function as the bridge between VM/StateManager, so also stuff like loading storage should move to the EEI (which calls into StateManager)
gabrocheleau
force-pushed
the
evm-vm-refactor-final
branch
2 times, most recently
from
3a0edf9 to
d4af503
Compare
ryanio
reviewed
May 19, 2022
ryanio
reviewed
May 19, 2022
ryanio
reviewed
May 19, 2022
…cated files, top-level EVM instantiation in VM
…e, afterMessage, newContract, step events to EVM
… options to EVM, removed EVM/Precompiles VM dependency
gabrocheleau
force-pushed
the
evm-vm-refactor-final
branch
from
d4af503 to
bc73342
Compare
ryanio
previously approved these changes
May 19, 2022
ryanio
reviewed
May 20, 2022
…n runBlock receipt ternary
gabrocheleau
force-pushed
the
evm-vm-refactor-final
branch
from
bc73342 to
08c647b
Compare
Hey :) Just tagging @holgerd77 for final approval & merge |
holgerd77
approved these changes
May 23, 2022
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
* VM -> EVM/VM Refactor: new EVMOpts EVM options dict, move common and supported HFs to EVM * VM -> EVM/VM Refactor: standalone DEBUG property in EVM and Interpreter * VM -> EVM/VM Refactor: standalone EVM stateManager option and property * VM -> EVM/VM Refactor: moved runCall()/runCode() to EVM, deleted dedicated files, top-level EVM instantiation in VM * VM -> EVM/VM Refactor: made EVM AsyncEventEmitter, moved beforeMessage, afterMessage, newContract, step events to EVM * VM -> EVM/VM Refactor: moved allowUnlimitedContractSize option to EVM * VM -> EVM/VM Refactor: moved opcode and gas handler functionality and options to EVM, removed EVM/Precompiles VM dependency * Client: fix cliqueActiveSigners method assignments * VM: refactor TxContext to an interface * VM: improve Message class types and defaults handling * VM: refactor runCall and executeMessage into unified runCall * VM: fix gas refund reset to 0 after tx finishes and fix parenthesis in runBlock receipt ternary * VM: reimplement transient storage clear method * VM: use VM async create method instead of constructor * VM: unify interpreter and evm DEBUG property Co-authored-by: Holger Drewes <Holger.Drewes@gmail.com>
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
* VM -> EVM/VM Refactor: new EVMOpts EVM options dict, move common and supported HFs to EVM * VM -> EVM/VM Refactor: standalone DEBUG property in EVM and Interpreter * VM -> EVM/VM Refactor: standalone EVM stateManager option and property * VM -> EVM/VM Refactor: moved runCall()/runCode() to EVM, deleted dedicated files, top-level EVM instantiation in VM * VM -> EVM/VM Refactor: made EVM AsyncEventEmitter, moved beforeMessage, afterMessage, newContract, step events to EVM * VM -> EVM/VM Refactor: moved allowUnlimitedContractSize option to EVM * VM -> EVM/VM Refactor: moved opcode and gas handler functionality and options to EVM, removed EVM/Precompiles VM dependency * Client: fix cliqueActiveSigners method assignments * VM: refactor TxContext to an interface * VM: improve Message class types and defaults handling * VM: refactor runCall and executeMessage into unified runCall * VM: fix gas refund reset to 0 after tx finishes and fix parenthesis in runBlock receipt ternary * VM: reimplement transient storage clear method * VM: use VM async create method instead of constructor * VM: unify interpreter and evm DEBUG property Co-authored-by: Holger Drewes <Holger.Drewes@gmail.com>
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
* VM -> EVM/VM Refactor: new EVMOpts EVM options dict, move common and supported HFs to EVM * VM -> EVM/VM Refactor: standalone DEBUG property in EVM and Interpreter * VM -> EVM/VM Refactor: standalone EVM stateManager option and property * VM -> EVM/VM Refactor: moved runCall()/runCode() to EVM, deleted dedicated files, top-level EVM instantiation in VM * VM -> EVM/VM Refactor: made EVM AsyncEventEmitter, moved beforeMessage, afterMessage, newContract, step events to EVM * VM -> EVM/VM Refactor: moved allowUnlimitedContractSize option to EVM * VM -> EVM/VM Refactor: moved opcode and gas handler functionality and options to EVM, removed EVM/Precompiles VM dependency * Client: fix cliqueActiveSigners method assignments * VM: refactor TxContext to an interface * VM: improve Message class types and defaults handling * VM: refactor runCall and executeMessage into unified runCall * VM: fix gas refund reset to 0 after tx finishes and fix parenthesis in runBlock receipt ternary * VM: reimplement transient storage clear method * VM: use VM async create method instead of constructor * VM: unify interpreter and evm DEBUG property Co-authored-by: Holger Drewes <Holger.Drewes@gmail.com>
g11tech
pushed a commit
that referenced
this pull request
Jun 3, 2022
* VM -> EVM/VM Refactor: new EVMOpts EVM options dict, move common and supported HFs to EVM * VM -> EVM/VM Refactor: standalone DEBUG property in EVM and Interpreter * VM -> EVM/VM Refactor: standalone EVM stateManager option and property * VM -> EVM/VM Refactor: moved runCall()/runCode() to EVM, deleted dedicated files, top-level EVM instantiation in VM * VM -> EVM/VM Refactor: made EVM AsyncEventEmitter, moved beforeMessage, afterMessage, newContract, step events to EVM * VM -> EVM/VM Refactor: moved allowUnlimitedContractSize option to EVM * VM -> EVM/VM Refactor: moved opcode and gas handler functionality and options to EVM, removed EVM/Precompiles VM dependency * Client: fix cliqueActiveSigners method assignments * VM: refactor TxContext to an interface * VM: improve Message class types and defaults handling * VM: refactor runCall and executeMessage into unified runCall * VM: fix gas refund reset to 0 after tx finishes and fix parenthesis in runBlock receipt ternary * VM: reimplement transient storage clear method * VM: use VM async create method instead of constructor * VM: unify interpreter and evm DEBUG property Co-authored-by: Holger Drewes <Holger.Drewes@gmail.com>
holgerd77
added a commit
that referenced
this pull request
Jun 8, 2022
* VM -> EVM/VM Refactor: new EVMOpts EVM options dict, move common and supported HFs to EVM * VM -> EVM/VM Refactor: standalone DEBUG property in EVM and Interpreter * VM -> EVM/VM Refactor: standalone EVM stateManager option and property * VM -> EVM/VM Refactor: moved runCall()/runCode() to EVM, deleted dedicated files, top-level EVM instantiation in VM * VM -> EVM/VM Refactor: made EVM AsyncEventEmitter, moved beforeMessage, afterMessage, newContract, step events to EVM * VM -> EVM/VM Refactor: moved allowUnlimitedContractSize option to EVM * VM -> EVM/VM Refactor: moved opcode and gas handler functionality and options to EVM, removed EVM/Precompiles VM dependency * Client: fix cliqueActiveSigners method assignments * VM: refactor TxContext to an interface * VM: improve Message class types and defaults handling * VM: refactor runCall and executeMessage into unified runCall * VM: fix gas refund reset to 0 after tx finishes and fix parenthesis in runBlock receipt ternary * VM: reimplement transient storage clear method * VM: use VM async create method instead of constructor * VM: unify interpreter and evm DEBUG property Co-authored-by: Holger Drewes <Holger.Drewes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of #1862
Resolves #528