Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devp2p-crypto-dependencies #1942

Closed
wants to merge 5 commits into from
Closed

Devp2p-crypto-dependencies #1942

wants to merge 5 commits into from

Conversation

ScottyPoi
Copy link
Contributor

@ScottyPoi ScottyPoi commented Jun 8, 2022 •
edited
Loading

Fixes for #1934
Resubmission of #1939 on Master

Removes dependencies on secp256k1 and keccak packages in favor of ethereum-cryptography

@ScottyPoi ScottyPoi added PR state: WIP dependencies Pull requests that update a dependency file package: devp2p target: master Work to be done towards master branch labels Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022 •
edited
Loading

Codecov Report

Merging #1942 (4f88100) into master (3e4e7be) will increase coverage by 2.10%.
The diff coverage is 90.00%.

Impacted file tree graph

Flag Coverage Δ
block 85.57% <ø> (ø)
blockchain ?
client ?
common 94.19% <ø> (ø)
devp2p 82.49% <90.00%> (-0.20%) ⬇️
ethash ?
trie 80.64% <ø> (+0.62%) ⬆️
tx 88.28% <ø> (ø)
util 92.63% <ø> (ø)
vm 81.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

holgerd77 commented Jun 8, 2022 •
edited
Loading

Wait wait, young Padavan, resubmission to master after we have merged in develop, so after the merge of #1943 (this is now the case). 😜

So now is the time to re-submit. 🙂

@ScottyPoi ScottyPoi closed this Jun 8, 2022
@ScottyPoi ScottyPoi deleted the devp2p-crypto-dependencies branch June 8, 2022 19:07
@holgerd77
Copy link
Member

Has this been resubmitted at some point?

It would be nice to have this at least in Beta 2, Beta 1 wouldn't hurt either.

@holgerd77
Copy link
Member

Update: ah, just seeing, re-submitted in #1947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file package: devp2p PR state: WIP target: master Work to be done towards master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottyPoi @holgerd77