Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

develop clean-up items #1944

Merged
merged 1 commit into from
Jun 8, 2022
Merged

develop clean-up items #1944

merged 1 commit into from
Jun 8, 2022

Conversation

acolytec3
Copy link
Contributor

Clean-up items following on #1943

  • Removes bigint-crypto-utils dep from root package.json
  • Fixes memory leak in EIP-3074 tests where common isn't copied and the hardfork listener gets duplicated

@codecov
Copy link

codecov bot commented Jun 8, 2022 •
edited
Loading

Codecov Report

Merging #1944 (29ced53) into master (4481cf2) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 86.15% <ø> (ø)
blockchain 81.72% <ø> (ø)
client 78.35% <ø> (-0.05%) ⬇️
common 95.01% <ø> (ø)
devp2p 82.51% <ø> (-0.20%) ⬇️
ethash 90.81% <ø> (ø)
statemanager 84.55% <ø> (ø)
trie 80.19% <ø> (-0.50%) ⬇️
tx 92.18% <ø> (ø)
util 87.32% <ø> (ø)
vm 80.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 8a65e19 into master Jun 8, 2022
@holgerd77 holgerd77 deleted the develop-cleanup branch June 8, 2022 11:05
@holgerd77
Copy link
Member

15 minutes over. 😅

Nice that you tackled so quickly! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: monorepo package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acolytec3 @holgerd77