Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release v2.3.0 #216

Merged
merged 1 commit into from
Oct 11, 2017
Merged

New release v2.3.0 #216

merged 1 commit into from
Oct 11, 2017

Conversation

holgerd77
Copy link
Member

@holgerd77 holgerd77 commented Oct 10, 2017

Versioned Byzantium release, will be published on npm after merge.

Depends on:
ethereumjs/ethereumjs-block#37
ethereumjs/rustbn.js#6
ethereumjs/ethereumjs-blockchain#36
ethereumjs/common#9

See: #209

"description": "an ethereum VM implementation",
"main": "index.js",
"dependencies": {
"async": "^2.1.2",
"async-eventemitter": "^0.2.2",
"ethereum-common": "https://github.com/ethereumjs/common",
"ethereum-common": "0.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break in the mean-time that the 0.2.0 is tagged on github, but not pushed to npm?

We can use git urls like git+https://github.com/ethereumjs/common.git#v0.2.0 instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in the process of amending these release PRs to do exactly this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: comment is outdated, this has been discussed on Gitter, leave npm versions, PRs just have to be merged/published on npm in given order.

Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwasinger jwasinger merged commit 496618d into master Oct 11, 2017
@axic axic deleted the new-release-230 branch October 12, 2017 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants