-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release v2.3.0 #216
New release v2.3.0 #216
Conversation
"description": "an ethereum VM implementation", | ||
"main": "index.js", | ||
"dependencies": { | ||
"async": "^2.1.2", | ||
"async-eventemitter": "^0.2.2", | ||
"ethereum-common": "https://github.com/ethereumjs/common", | ||
"ethereum-common": "0.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this break in the mean-time that the 0.2.0 is tagged on github, but not pushed to npm?
We can use git urls like git+https://github.com/ethereumjs/common.git#v0.2.0
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in the process of amending these release PRs to do exactly this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: comment is outdated, this has been discussed on Gitter, leave npm versions, PRs just have to be merged/published on npm in given order.
ea23b8a
to
dc50917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Versioned Byzantium release, will be published on npm after merge.
Depends on:
ethereumjs/ethereumjs-block#37ethereumjs/rustbn.js#6ethereumjs/ethereumjs-blockchain#36ethereumjs/common#9See: #209