Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule shanghai on sepolia #2527

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Schedule shanghai on sepolia #2527

merged 2 commits into from
Feb 10, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Feb 10, 2023 •
edited
Loading

@g11tech g11tech force-pushed the g11tech/sepolia-shanghai branch from 458732b to 8823378 Compare February 10, 2023 10:41
@codecov
Copy link

codecov bot commented Feb 10, 2023 •
edited
Loading

Codecov Report

Merging #2527 (75e1941) into master (86d353a) will decrease coverage by 0.49%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.10% <ø> (ø)
blockchain ?
client 87.81% <ø> (ø)
common ?
devp2p 91.59% <ø> (-0.17%) ⬇️
ethash ∅ <ø> (∅)
evm 83.35% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager ?
trie 90.66% <ø> (ø)
tx 93.71% <ø> (ø)
util 84.48% <ø> (ø)
vm 84.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech force-pushed the g11tech/sepolia-shanghai branch from 04b25d9 to 75e1941 Compare February 10, 2023 11:35
holgerd77
holgerd77 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, re-checked the values, LGTM!

@holgerd77 holgerd77 merged commit 562b0ff into master Feb 10, 2023
@holgerd77 holgerd77 deleted the g11tech/sepolia-shanghai branch February 10, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
hardfork: shanghai package: common PR state: merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g11tech @holgerd77