Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal rlpx test suite #3126

Merged
merged 13 commits into from
Nov 1, 2023
Merged

Minimal rlpx test suite #3126

merged 13 commits into from
Nov 1, 2023

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Oct 30, 2023 •
edited
Loading

  • Adds a minimal test suite for the rlpx class, with much help from CodiumAI robots
  • Fixes devp2p so it pushes code coverage reports again

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #3126 (7be5ea5) into master (ce9ff22) will decrease coverage by 0.19%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.80% <ø> (ø)
blockchain 92.27% <ø> (ø)
client 86.21% <ø> (+0.04%) ⬆️
common 98.19% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.93% <ø> (ø)
statemanager ?
trie 90.01% <ø> (+0.62%) ⬆️
tx 96.36% <ø> (ø)
util 87.53% <ø> (ø)
vm 76.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3
Copy link
Contributor Author

Looks like devp2p test coverage isn't being uploaded to CodeCoverage for some reason but here's what c8 says about coverage increase:
On current master
image

On this pr
image
So, somewhat better.

@holgerd77
Copy link
Member

Updated this via UI

@holgerd77
Copy link
Member

Updated this via UI

holgerd77
holgerd77 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are fantastic new tests I will take as some reference tests for myself from now on how to deal with this vi mocking, super great and insightful! 🤩

Will merge.

@holgerd77 holgerd77 merged commit ab4ba34 into master Nov 1, 2023
44 checks passed
@holgerd77 holgerd77 deleted the rlpx-tests branch November 1, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: devp2p PR state: needs review type: refactor type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acolytec3 @holgerd77