-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monorepo: revert and adjust some prefixedHexTypes #3382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cool 🎉, can you also add a note to #3216 ? |
td?: BigIntLike | ||
blockNumber?: BigIntLike | string | ||
timestamp?: BigIntLike | string | ||
td?: BigIntLike | string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. This seems wrong I guess?
I could instantly spot too missed instances, (or are these not breaking for some reasons?) |
Circling back to this. I don't think that methods that output |
Addressed in #3427 @holgerd77 |
This PR reverts some updates that had been made to
string
in #3348 and #3357, where string types were updated toPrefixedHexString
when that was relevant, but this can lead to breaking changes in certain contexts. I've reverted what seemed like the most obvious common usages (e.g. block or common types that can be used externally). Instead of actually reverting tostring
, I updated the types toPrefixedHexString | string
so that we can easily eventually removestring
fully. I've also added TODO's above each of these instances so we can quickly retieve these instances and do that eventually.