Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/Revise EIP 6610 #3390

Merged
merged 7 commits into from
May 3, 2024
Merged

Implement/Revise EIP 6610 #3390

merged 7 commits into from
May 3, 2024

Conversation

acolytec3
Copy link
Contributor

Rework of EIP 6110 based on #3303

const requests: CLRequest[] = []
const common = vm.common

// TODO: Add in code to accumulate deposits (EIP-6110)
if (common.isActivatedEIP(6110)) {
await accumulateDeposits(txResults, requests)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accumulate7002 is with _ while this is not, may be we take a consistent approach

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acolytec3 acolytec3 merged commit 8735f48 into master May 3, 2024
33 of 34 checks passed
@holgerd77 holgerd77 deleted the 6110-rework branch May 3, 2024 18:23
@holgerd77
Copy link
Member

@scorbajio Cool, congrats, great work 🤩, and thanks @acolytec3 for the revision! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EIP-6110] Supply validator deposits on chain
4 participants