Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verkle: rename verkle utils and refactor #3468

Merged
merged 5 commits into from
Jun 22, 2024
Merged

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented Jun 21, 2024

This PR updates the verkle utils namespace so that they are clearer in the context of being exported from the util package rather than the verkle package. It also ports over some tests from verkle to util.

@gabrocheleau gabrocheleau changed the title verkle: rename verkle utils verkle: rename verkle utils and refactor Jun 21, 2024
@acolytec3 acolytec3 merged commit 22612f2 into master Jun 22, 2024
33 of 34 checks passed
@acolytec3 acolytec3 deleted the verkle/rename-verkle-utils branch June 22, 2024 02:17
@holgerd77
Copy link
Member

Cool, thanks for addressing so quickly, great to now have this "round"! 🙂 ❤️

I think I would be a fan of also moving matchingBytesLength() over to Util bytes, even if it might not be totally apparent if there will be other usages. But this is such a generic function that it's worth to "offer as a service" (who knows what other users are doing) and then we have this out of Verkle.

At along maybe we can even (already) move the PrioritizedTaskExecutor over and also integrate into Trie to make the round-trip. Would also make sense and then we can simply kill off the whole util folder from Verkle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants