Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detach precompiles from VM #492

Merged
merged 2 commits into from
Apr 8, 2019
Merged

Detach precompiles from VM #492

merged 2 commits into from
Apr 8, 2019

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Apr 8, 2019

This PR:

  • Drops vm._precompiled
  • Exports list of precompiles (indexed by their address) in lib/evm/precompiles/index
  • Adds codeAddress to Message which is used in Interpreter to load code
  • Adds getPrecompile method to Interpreter which can be overloaded for custom precompiles

(To be merged into #479)

holgerd77
holgerd77 approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@s1na s1na merged commit ac60927 into v4 Apr 8, 2019
@s1na s1na deleted the refactor/precompiles branch April 8, 2019 12:37
@s1na s1na mentioned this pull request Apr 8, 2019
Merged
23 tasks
@holgerd77 holgerd77 mentioned this pull request Jun 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s1na @holgerd77 @evertonfraga