Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release v4.0.0-beta.1 #547

Merged
merged 1 commit into from
Jun 19, 2019
Merged

New release v4.0.0-beta.1 #547

merged 1 commit into from
Jun 19, 2019

Conversation

holgerd77
Copy link
Member

Ok, have compiled down a first version of release notes 😄, this is still WIP though.

@holgerd77 holgerd77 mentioned this pull request Jun 15, 2019
Closed
7 tasks
@coveralls
Copy link

coveralls commented Jun 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 95.087% when pulling aaec0e2 on new-release-v400-beta1 into febef66 on master.

@holgerd77
Copy link
Member Author

Note: use "view file" on the changelog for the rendered version.

@holgerd77
Copy link
Member Author

@s1na Ok, this is now ready for review. 😄

@holgerd77
Copy link
Member Author

@s1na Baby 👶 sleeps and I have from now on roughly an hour to do stuff. If you read this short term it would be appreciated if you can do a (somewhat generous on spelling errors or similar) review on this, then I could take the time for the release.

s1na
s1na reviewed Jun 19, 2019
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very comprehensive with great explanations. Thanks a lot Holger!

Just had one minor question, otherwise I think we're ready :)

CHANGELOG.md Outdated

##### Version Updates

- [BREAKING] Updated `ethereumjs-account` from `2.x` to `3.x`, part of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I get why this is a breaking change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was meant in the sense of "people have to update their dependencies", but you are right, not really something which can be considered "breaking", have removed the label.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you see and are fine with the update please re-approve.

CHANGELOG.md
Breaking changes in the release notes are preeceeded with `[BREAKING]`, do a
search for an overview.

The outstanding work of [@s1na](https://github.com/s1na) has to be mentioned
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

s1na
s1na approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To v4.0.0-beta and beyond 🚀 😄

@holgerd77
Copy link
Member Author

Hehe. Thanks. 😄

@holgerd77 holgerd77 merged commit df5a1b5 into master Jun 19, 2019
@holgerd77 holgerd77 deleted the new-release-v400-beta1 branch June 19, 2019 10:02
@holgerd77
Copy link
Member Author

Out and posted all over the place. 😛

@s1na Thanks again for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1na s1na s1na approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holgerd77 @coveralls @s1na @evertonfraga