Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI concurrency #804

Merged
merged 10 commits into from
Jul 30, 2020
Merged

CI concurrency #804

merged 10 commits into from
Jul 30, 2020

Conversation

evertonfraga
Copy link
Contributor

@evertonfraga evertonfraga commented Jun 30, 2020

  • Split VM state tests to reduce critical path
    Latest run on master: 17min
    Target: 6min (worst case), +2 jobs per PR run

  • Split VM blockchain tests
    Latest run on master: 11min
    Target: 6min (worst case), +1 job per PR run

  • Reduce amount of jobs running on PRs
    Run PR tests only in one Node version -18 jobs per PR run

  • Fix VM coverage reporting
    It seems it has stopped working

  • Reduce amount of information on codecov comments

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #804 into master will increase coverage by 5.09%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
#account 92.85% <ø> (ø)
#block 80.35% <ø> (ø)
#blockchain 84.71% <ø> (ø)
#common 94.14% <ø> (+0.15%) ⬆️
#ethash 85.40% <ø> (-0.90%) ⬇️
#tx 94.02% <ø> (ø)
#vm 93.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@evertonfraga evertonfraga force-pushed the ci-concurrency branch 2 times, most recently from 38a4a95 to ab463f7 Compare June 30, 2020 20:56
@evertonfraga
Copy link
Contributor Author

Simplifying codecov output:

Screen Shot 2020-07-23 at 12 01 45 PM

Screen Shot 2020-07-23 at 12 29 30 PM

@evertonfraga evertonfraga requested a review from ryanio July 28, 2020 18:40
@evertonfraga evertonfraga marked this pull request as ready for review July 28, 2020 18:40
ryanio
ryanio previously approved these changes Jul 28, 2020
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -1,6 +0,0 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File deleted intentionally.

@evertonfraga evertonfraga merged commit 865a955 into master Jul 30, 2020
@evertonfraga evertonfraga deleted the ci-concurrency branch July 30, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants