Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta.2 Releases #946

Merged
merged 7 commits into from
Nov 12, 2020
Merged

Beta.2 Releases #946

merged 7 commits into from
Nov 12, 2020

Conversation

holgerd77
Copy link
Member

Part of #907

Second beta release series for the VM v5 and other monorepo libraries following #922

All libraries except the Ethash library get a new release.

(can be best reviewed on a per-commit basis)

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #946 (96504cc) into master (daf1bb7) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 75.04% <ø> (-0.33%) ⬇️
blockchain 77.39% <ø> (ø)
common 91.87% <ø> (ø)
ethash 82.08% <ø> (ø)
tx 86.25% <ø> (ø)
vm 87.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member Author

Ok, this is now ready for review. I now also updated the README files along with this and did most of the tiny fixes from #905

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit comment, rest LGTM! 😄

@holgerd77
Copy link
Member Author

@jochem-brouwer can you give this a short re-approval? I needed to update the branch here since there was some other PR merged in between (I think I would otherwise do an exception and do an admin-merge here, don't want to postpone the releases just for this)

@holgerd77
Copy link
Member Author

@jochem-brouwer update: ah, seems this is necessary only on rebases and not on branch updates (which I did here), no no need for re-approval! 😄 Actually a reason to use this branch update feature a bit more often on somewhat uncritical updates.

@holgerd77 holgerd77 merged commit d8e7066 into master Nov 12, 2020
@holgerd77 holgerd77 deleted the beta.2-releases branch November 12, 2020 08:04
@holgerd77
Copy link
Member Author

Just published the following releases on npm 😄 :

@holgerd77 holgerd77 mentioned this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants