Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

New release v1.3.3 #49

Merged
merged 2 commits into from
Aug 5, 2020
Merged

New release v1.3.3 #49

merged 2 commits into from
Aug 5, 2020

Conversation

holgerd77
Copy link
Member

Hi @jochem-brouwer, if this is matching with the release you need here please review (approve) or otherwise let me know.

@jochem-brouwer
Copy link
Member

Hey @holgerd77, this depends upon this comment on the "fix tests" PR in the VM. The Blockchain/State tests are there inconsistent (the filter logic in State is in the VM code, but your comment (if I understand it correctly) says that the filtering should be in the tests repo or not).

So we have two choices there, we either keep the filtering in the VM (which happens for State) or we add an extra parameter (like a "fork" parameter) to this tests repo.

This PR for updating tests looks good to me, but lets first resolve this discussion 😄

@holgerd77
Copy link
Member Author

@jochem-brouwer Should we merge ethereumjs/ethereumjs-monorepo#808 as suggested in this comment, @evertonfraga any objections?

That was also be a bit the background idea when opening this PR. Then you can integrate/update the code where ever you think it fits within the VM test runner (and eventually also do some modernization along if you like to)?

@jochem-brouwer jochem-brouwer merged commit eb8aff6 into master Aug 5, 2020
@evertonfraga evertonfraga deleted the new-release branch August 5, 2020 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants