Do not set default zero adress, only include signature with from set …

…in fake transaction (undo PR #94)
ethereumjs · Jun 29, 2018 · 2dfdae9 · 2dfdae9
1 parent 2aa7e54
commit 2dfdae9
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/fake.js b/fake.js
@@ -49,8 +49,7 @@ module.exports = class FakeTransaction extends Transaction {
       }
     })
 
-    // set from address or default to null address
-    this.from = (data && data.from) ? data.from : '0x0000000000000000000000000000000000000000'
+    this.from = data.from
   }
 
   /**
@@ -59,7 +58,7 @@ module.exports = class FakeTransaction extends Transaction {
    * @return {Buffer}
    */
   hash (includeSignature = true) {
-    if (includeSignature) {
+    if (includeSignature && this._from && this._from.toString('hex') !== '') {
       // include a fake signature using the from address as a private key
       let fakeKey = Buffer.concat([this._from, this._from.slice(0, 12)])
       this.sign(fakeKey)