-
Notifications
You must be signed in to change notification settings - Fork 238
Update Travis to run on Node v8 and v10; Add tests for inherited FakeTransaction functions #138
Conversation
This has a linting error, also |
One procedural note: can you use the PR-marked labels for your pull requests - primarily the WIP and Ready-for-review (only once tests passes) labels? Then it get's easier to judge if a PR is ready. You can also request specific reviewers if you like (not necessarily me). |
That said: thanks for the various PRs! 👍 😄 |
Thanks for the housekeeping notes @holgerd77 ! I will address the comments on various PRs over the next 3-5 days |
👍 |
d7c98ea
to
4d75731
Compare
Hi @chikeichan can you bring this up-to-date? |
This looks good to me. The only method not directly tested is About the travis part. Should it include v11? It is the Current version now, but that'll change in a few weeks, and its EOL is in two months. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by @alcuadrado, will merge, thanks @chikeichan!
Fixes #114
Opening this one on top of #131 - I will change merge target to master when #131 is merged.