This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Fix browserify issue #119
Merged
Fix browserify issue #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid 3rd-party build conflicts
holgerd77
force-pushed
the
fix-browserify-issue
branch
from
d0daf4b to
ba1ae59
Compare
Silur
reviewed
Feb 20, 2018
| @@ -17,18 +17,6 @@ | |||
| "build:dist": "babel index.js --source-root ./ -d ./dist", | |||
| "build:docs": "documentation build ./index.js --github --sort-order='alpha' -f md > ./docs/index.md" | |||
| }, | |||
| "browserify": { | |||
There was a problem hiding this comment.
maybe leave this as a script for containers etc are not forced to have a global browserify in PATH and only npm ... scripts can access the .bin dir to hook up a dependency?
There was a problem hiding this comment.
I think this was never meant to be used for browserify itself but is just used internally for karma testing. Or am I wrong here?
There was a problem hiding this comment.
Yes there is no browserify in the build for this module - it's only for karma
alanshaw
approved these changes
Feb 20, 2018
|
Ping! Can has merge+release plz? |
|
@alanshaw Sorry, forgot about that one, just merged, will prepare a minor release asap. |
|
thank you @holgerd77 ✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as in
ethereumjs-block, see ethereumjs/ethereumjs-block#40.Also fixes #118.