Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Enforce buffer inputs for account methods #245

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Enforce buffer inputs for account methods #245

merged 3 commits into from
Apr 24, 2020

Conversation

cgewecke
Copy link
Contributor

PR #243 was accidentally merged into the wrong branch...this is the same pointed at Master

Part of #172 Breaking API Changes

  • Removes implicit Buffer conversion in accounts.ts
  • Removes support for string inputs to generateAddress2
  • Enforces Buffer inputs for
    • generateAddress
    • generateAddress2
    • pubToAddress
    • privateToPublic
    • importPublic

isPrecompiled is ignored here because it's targeted for removal in #242

@github-actions
Copy link

Coverage Status

Coverage increased (+0.006%) to 99.659% when pulling 3aa8a75 on enforce-buffer-accounts into ebe0723 on master.

@cgewecke cgewecke requested a review from holgerd77 April 24, 2020 16:48
holgerd77
holgerd77 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 2e0ec40 into master Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgewecke @holgerd77