Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

problem: eth_sign should accept variable data param #513

Merged
merged 1 commit into from
Feb 28, 2018
Merged

problem: eth_sign should accept variable data param #513

merged 1 commit into from
Feb 28, 2018

Conversation

whilei
Copy link
Contributor

@whilei whilei commented Feb 23, 2018 •
edited
Loading

@whilei
problem: eth_sign should accept variable data param
2b3b03e 
and should return a Prefixed signed hash

solution: implement keccak signing for arbitrary, prefixed data
and return signed hash

resolves #512
@whilei
Copy link
Contributor Author

whilei commented Feb 26, 2018

cc/ @tzdybal

--- FAIL: TestBcForkUncleTests (0.09s)
	block_test.go:56: ForkUncle: lastblockhash validation mismatch: want: 326971f0690f5557832ba60190f1f84010c4b18f4fb17e91d99e821e2cff2a2d, have: a307f8d0c778cdf3eda56bd70b0dbe217906c412de5ce0f21687e4805fefa575
FAIL
FAIL	github.com/ethereumproject/go-ethereum/tests	26.896s

tzdybal
tzdybal approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whilei whilei merged commit 73bb4c8 into master Feb 28, 2018
@soc1c soc1c deleted the fix/eth-sign branch June 19, 2019 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tzdybal tzdybal tzdybal approved these changes

@r8d8 r8d8 Awaiting requested review from r8d8

@gagarin55 gagarin55 Awaiting requested review from gagarin55

@sorpaas sorpaas Awaiting requested review from sorpaas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whilei @tzdybal