Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

Fix/vendor rjeczalik notify (peg at vendor's revision containing fix) #582

Merged
merged 2 commits into from
May 8, 2018
Merged

Fix/vendor rjeczalik notify (peg at vendor's revision containing fix) #582

merged 2 commits into from
May 8, 2018

Conversation

whilei
Copy link
Contributor

@whilei whilei commented May 8, 2018

whilei added 2 commits May 8, 2018 12:32
@whilei
problem: rjeczalik/notify: cannot use refZero (type int) as type *_Ct…
3589684 
…ype_struct___CFAllocator in argument to func literal

solution: peg dependency to vendor's revision in which a fix was introducted

Fixes #581
@whilei
solution: dep ensure
e6fb5cd
@whilei whilei requested review from tzdybal and r8d8 May 8, 2018 03:34
tzdybal
tzdybal approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it actually resolves the issue for you, LGTM.

@whilei whilei merged commit 867b073 into master May 8, 2018
@soc1c soc1c deleted the fix/vendor-rjeczalik-notify branch June 19, 2019 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tzdybal tzdybal tzdybal approved these changes

@r8d8 r8d8 Awaiting requested review from r8d8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whilei @tzdybal