This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
fix atxi pagination OoB possibility #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solution: ensure param within len lim Fixes #626
tzdybal
reviewed
Jun 9, 2018
core/atxi.go
Outdated
| @@ -367,9 +367,13 @@ func GetAddrTxs(db ethdb.Database, address common.Address, blockStartN uint64, b | |||
| } | |||
| if paginationStart < 0 { | |||
| paginationStart = 0 | |||
| } else if paginationStart > len(s) { | |||
| paginationStart = len(s) | |||
| } | |||
| if paginationEnd < 0 { | |||
There was a problem hiding this comment.
This can be simplified to:
if paginationEnd < 0 || paginationEnd > len(s) {
paginationEnd = len(s)
}
solution: refactor core/ getter method to return an error, if any api can then provide user with more helpful debugging
|
@tzdybal |
solution: fix signatures, add a small test, and fix param condition
|
Maybe actually fixed. |
|
Reviewed 2 of 3 files at r2, 3 of 3 files at r3. Comments from Reviewable |
tzdybal
approved these changes
Jun 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: atxi pagination param can cause slice OoB
solution: ensure param within len lim
Fixes #626