This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
Fix/appveyor sputnikvm ffi #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add --verbose flag to build cmd for debugging
- build sputnikvm-ffi from vendored source, and move c file to vendored source, adjusting go build tags accordingly
r8d8
approved these changes
Nov 7, 2018
tzdybal
approved these changes
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: Windows builds failing on master b/c
sputnikvm-ffinot able to compile. Likely related to issues around #675 .solution here: Build from w/in
vendor/dir instead ofgo/.../ETCDEVTeam/sputnikvm-ffi/to allow build to be determined bydepversion control instead of sputnikvm-ffi master.