remove unused fee values from pool (#478) #480

doerfli · 2024-07-04T08:28:09Z

these fees were no longer being used, so they can as well be removed

github-actions · 2024-07-04T08:48:15Z

Todo Commenter

contracts/pool/PoolService.sol

staking amount must be be > maxCapitalAmount Line: 131
restricted() (once Authz: Authorize component service call #462 is done) Line: 189
restricted() (once Authz: Authorize component service call #462 is done) Line: 238
handle performance fees (issue Implement performance fees #477) Line: 260
centralize token handling (issue Centralize token transfer code #471) Line: 283
centralize token handling (issue Centralize token transfer code #471) Line: 515

@doerfli Please take a look 👀

remove unused fee values from pool (closes #478)

2cf306b

doerfli linked an issue Jul 4, 2024 that may be closed by this pull request

Rename pool and distribution fees to **initial**[...]Fees #478

Closed

return effective staked amount when creating bundle (#478)

278a31a

doerfli requested a review from matthiaszimmermann July 4, 2024 08:49

Base automatically changed from feature/bundle-stake-unstake-extend to develop July 8, 2024 08:25

doerfli merged commit 05c3308 into develop Jul 8, 2024
6 checks passed

doerfli deleted the feature/rename-dist-pool-fees branch July 8, 2024 08:25

github-actions bot locked and limited conversation to collaborators Jul 8, 2024