Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/introduce release admin #560

Merged
merged 25 commits into from
Aug 19, 2024

Conversation

rapidddenis
Copy link
Collaborator

@rapidddenis rapidddenis commented Jul 27, 2024

  • AccessManagerCloneable: add setLocked()
  • AccessManagerCloneable: check caller/target lock
  • introduce ReleaseAdmin with release lock feature
  • InstanceAdmin : add setInstanceLocked()
  • AccessAdmin: insure targets and roles are created before usage
  • ReleaseRegistry: refactor release lock into setActive()

Copy link

gitguardian bot commented Jul 27, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11712615 Triggered Generic High Entropy Secret cdd6ad7 test/registryService/RegistryServiceTestBase.sol View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@matthiaszimmermann matthiaszimmermann changed the title Feature/release access manager Feature/release admin Jul 30, 2024
@matthiaszimmermann matthiaszimmermann changed the title Feature/release admin Feature/introduce release admin Jul 30, 2024
@rapidddenis rapidddenis force-pushed the feature/release-access-manager branch from 5ae1b30 to 998fb56 Compare July 31, 2024 03:50
@rapidddenis
Copy link
Collaborator Author

implements #331

@rapidddenis rapidddenis force-pushed the feature/release-access-manager branch from 998fb56 to 3808954 Compare August 5, 2024 21:33
Copy link
Contributor

Todo Commenter

contracts/distribution/DistributionService.sol
TODO:
contracts/instance/InstanceAdmin.sol
FIXME:
  • make this a bit nicer and work with IAuthorization. Use a specific role, not public - access to TokenHandler must be restricted Line: 154
contracts/pool/PoolService.sol
TODO:
contracts/product/ApplicationService.sol
TODO:
  • add logging Line: 172

@matthiaszimmermann Please take a look 👀

@matthiaszimmermann matthiaszimmermann merged commit d43ca2d into develop Aug 19, 2024
12 checks passed
@matthiaszimmermann matthiaszimmermann deleted the feature/release-access-manager branch August 19, 2024 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants