-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/introduce release admin #560
Conversation
rapidddenis
commented
Jul 27, 2024
•
edited
Loading
edited
- AccessManagerCloneable: add setLocked()
- AccessManagerCloneable: check caller/target lock
- introduce ReleaseAdmin with release lock feature
- InstanceAdmin : add setInstanceLocked()
- AccessAdmin: insure targets and roles are created before usage
- ReleaseRegistry: refactor release lock into setActive()
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11712615 | Triggered | Generic High Entropy Secret | cdd6ad7 | test/registryService/RegistryServiceTestBase.sol | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
5ae1b30
to
998fb56
Compare
implements #331 |
…createReleaseAdmin()
…locked check, dissalow locking of release admin, add comments
998fb56
to
3808954
Compare
Todo Commentercontracts/distribution/DistributionService.solTODO:
contracts/instance/InstanceAdmin.solFIXME:
contracts/pool/PoolService.solTODO:
contracts/product/ApplicationService.solTODO:
@matthiaszimmermann Please take a look 👀 |