refactor events to improve parameter order and indexing (#787) #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doerfli
force-pushed
the
feature/events-refactoring
branch
from
7ef5c72 to
185308b
Compare
4 tasks
…e indexing and enhance event logging (#787)
…nce event logging (#787)
…er event filtering (#787)
…indexing for enhanced event filtering and logging (#787)
…g for enhanced event filtering and logging (#787)
…nced event filtering and logging (#787)
…ed event filtering and logging (#787)
…ter indexing for enhanced event filtering (#787)
… indexing for enhanced event filtering (#787)
…ced event filtering (#787)
…nhanced event filtering (#787)
…parameter indexing for enhanced event filtering (#787)
…anced event filtering (#787)
…e parameter indexing for enhanced event filtering (#787)
…rameter indexing for enhanced event filtering (#787)
doerfli
force-pushed
the
feature/events-refactoring
branch
from
d17e379 to
8c8e108
Compare
Todo Commentercontracts/instance/InstanceService.solTODO:
contracts/pool/PoolService.solTODO:
contracts/product/ClaimService.solTODO:
@doerfli Please take a look 👀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#787