Fix stray promises when a node returns invalid results (#4118).

ethers-io · Jun 6, 2023 · 3c1bad2 · 3c1bad2
1 parent f37a52d
commit 3c1bad2
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src.ts/providers/provider-jsonrpc.ts b/src.ts/providers/provider-jsonrpc.ts
@@ -505,7 +505,12 @@ export abstract class JsonRpcApiProvider extends AbstractProvider {
 
                             // No result; the node failed us in unexpected ways
                             if (resp == null) {
-                                return reject(makeError("no response from server", "BAD_DATA", { value: result, info: { payload } }));
+                                const error = makeError("missing response for request", "BAD_DATA", {
+                                    value: result, info: { payload }
+                                });
+                                this.emit("error", error);
+                                reject(error);
+                                continue;
                             }
 
                             // The response is an error