Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contract.listernerCount() errors when argument is left blank despite documentation saying you can leave it blank #1205

Closed
zimmah opened this issue Dec 17, 2020 · 4 comments
Closed

contract.listernerCount() errors when argument is left blank despite documentation saying you can leave it blank #1205

zimmah opened this issue Dec 17, 2020 · 4 comments
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@zimmah
Copy link

zimmah commented Dec 17, 2020

The documentation claims "If no event is provided, returns the total count of all events."

however, if you don't provide an event, you get: Uncaught (in promise) TypeError: Cannot read property 'topics' of undefined
@ricmoo ricmoo added investigate Under investigation and may be a bug. on-deck This Enhancement or Bug is currently being worked on. labels Dec 17, 2020
@ricmoo
Copy link
Member

ricmoo commented Dec 17, 2020

I’ll look into this shortly...

@ricmoo ricmoo added bug Verified to be an issue. and removed investigate Under investigation and may be a bug. labels Dec 18, 2020
@ricmoo
Copy link
Member

ricmoo commented Dec 18, 2020

I have verified this is a bug and have made local changes to address is. I'm a nit busy right now, but will publish it tomorrow. Thanks for reporting it! :)

ricmoo added a commit that referenced this issue Jan 8, 2021
@ricmoo
Fixed listenerCount for contract when requesting for all events (#1205).
a56a0a3
@ricmoo
Copy link
Member

ricmoo commented Jan 8, 2021

Sorry for the delay, lost track of this. This should be fixed in 5.0.25.

Try it out and let me know! :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jan 8, 2021
@zimmah
Copy link
Author

zimmah commented Jan 13, 2021

Seems good. Thanks

@zimmah zimmah closed this as completed Jan 13, 2021
This was referenced Mar 12, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @zimmah