"from address mismatch" when tx.from is lowercased

[miguelmota]

If tx.from is lowercased then this line throws the from address mismatch because it's comparing against a checksummed address. Would it be better to checksum the tx.from address and then do the comparison? since they're both the same address so I wouldn't expect it to throw.

ethers.js/packages/abstract-signer/src.ts/index.ts

Line 176 in e0ccafb

if (result[0] !== result[1]) {

[ricmoo]

Good catch. I'll roll this up into a few other changes going out soon.

Thanks! :)

[ricmoo]

I had to go the other way. Use toLowerCase on them both. Since this is a low-level base class, I try to minimize the dependencies, and the address checksum would add the keccak256 dependency, and depending on tree shaking could also drag in BigNumber.

This does bring up an issue I will address in v6, which is this means that if you use an IBAN/ICAP address, in the from field things will get dicey. That said, I think ICAP is all but dead, and I've been considering dropping support for it in v6 (a utility function will still exist for it though; it just won't be a first-class address format).

[miguelmota]

Awesome! sounds good, thanks 🙂

[ricmoo]

This should be addressed in 5.0.26. Please try it out and let me know. :)

[miguelmota]

Works great!! Closing as resolved.