-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSONRPCProvider breaks if network is "any" #1484
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
Comments
ricmoo
added
on-deck
This Enhancement or Bug is currently being worked on.
bug
Verified to be an issue.
and removed
investigate
Under investigation and may be a bug.
labels
Apr 20, 2021
I've confirmed and reproduced this, and will get to it ASAP. Thanks! :) |
ricmoo
added a commit
that referenced
this issue
Apr 20, 2021
This has been addressed in 5.1.3. Can you try it out and let me know? Thanks! :) |
ricmoo
added
fixed/complete
This Bug is fixed or Enhancement is complete and published.
and removed
on-deck
This Enhancement or Bug is currently being worked on.
labels
Apr 20, 2021
5.1.3 seems to be working for me, thanks for the quick fix! |
This was referenced May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
I believe #1371 has introduced a bug regarding using Web3Provider with "any" network.
If a provider is constructed:
Then the BaseProvider will query the network inside the constructor.
ethers.js/packages/providers/src.ts/base-provider.ts
Lines 483 to 487 in c0daf43
However, this will fail, because the JSONRPCSigner doesn't set
_eventLoopCache
until aftersuper()
ethers.js/packages/providers/src.ts/json-rpc-provider.ts
Lines 308 to 310 in c0daf43
And the following error is thrown:
The text was updated successfully, but these errors were encountered: