Dollar sign is valid identifier character but not accepted

[frangio]

Ethers.js doesn't accept function names with a dollar sign in them.

ethers.js/packages/abi/src.ts/fragments.ts

Line 1032 in 4e6d121

const regexIdentifier = new RegExp("^[A-Za-z_][A-Za-z0-9_]*$");

See the lexer definition in the Solidity repo:

An identifier in solidity has to start with a letter, a dollar-sign or an underscore and may additionally contain numbers after the first symbol.

[ricmoo]

Thanks. I’ll get to this along with another parser issue sometime this week.

[ricmoo]

This has been fixed in 5.3.1. Try it out and let me know if you have any issues.

Thanks! :)

[frangio]

@ricmoo Thank you! Seems to work.