Possible Bug on Result Class (abstract-coder.ts)

[dennohpeter]

Ethers Version

6.0.3

Search Terms

No response

Describe the Problem

.slice(-1) and .toArray() are not working as expected.

.slice(-1): - should return the last item in the array, instead it's return the whole array plus undefined element on index 0

.toArray(): should return an array of the input items, instead it's returning nested array [[]]

Code Snippet

import { Result } from "ethers";

// test Result
  let result = new Result(
    "0x000000",
    "0x000001",
    "0x000002",
    "0x000003",
    "0x000004"
  );

  // returns result array
  console.info({ result });

  // working fine; i.e slice(0, 1) returns the first element
  console.info({ resultFirstElement: result.slice(0, 1) });

  // ISSUE 1:
  // NOT working as expected; i.e slice(-1) returns the last element, instead it returns the whole array plus the undefined item
  //    {
  //   resultLastElement: Result(6) [
  //     undefined,
  //     '0x000000',
  //     '0x000001',
  //     '0x000002',
  //     '0x000003',
  //     '0x000004'
  //   ]
  // }
  console.info({ resultLastElement: result.slice(-1) });

  console.info({ restOfTheElements: result.slice(1) });

  // ISSUE 2:
  // NOT working as expected; i.e toArray() returns Array of Result Array, instead of Array of Strings
  // actual result: {
  //   toArray: [
  //     Result(5) [
  //       '0x000000',
  //       '0x000001',
  //       '0x000002',
  //       '0x000003',
  //       '0x000004'
  //     ]
  //   ]
  // }

  // expected result: [ '0x000000', '0x000001', '0x000002', '0x000003', '0x000004' ]
  console.info({ toArray: result.toArray() });

  // Comparing with Array
  let arr = new Array(
    "0x000000",
    "0x000001",
    "0x000002",
    "0x000003",
    "0x000004"
  );

  console.info({ arr });

  // working fine working; i.e slice(0, 1) returns the first element
  console.info({ arrFirstElement: arr.slice(0, 1) });

  // working fine; i.e slice(-1) returns the last element
  console.info({ arrLastElement: arr.slice(-1) });

  // working fine; i.e slice(1) returns elements from index 1 to the end
  console.info({ restOfTheElements: arr.slice(1) });

Contract ABI

No response

Errors

No response

Environment

node.js (v12 or newer)

Environment (Other)

No response

[ricmoo]

Fixed in v6.0.5.

Thanks! :)