Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@adraffy/ens-normalize resolution #4102

Closed
omnus opened this issue May 30, 2023 · 7 comments
Closed

@adraffy/ens-normalize resolution #4102

omnus opened this issue May 30, 2023 · 7 comments
Assignees
Labels
fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6

Comments

@omnus
Copy link

omnus commented May 30, 2023

Ethers Version

6.4.0

Search Terms

dependencies ens

Describe the Problem

There is an existing (closed) issue relating to resolution of @adraffy/ens-normalize (#3848)

I'm still seeing this issue in 6.4.0, and I don't have any fancy react in my repo :). I think it has something to do with how npm is handling the nested dependency.

If I install @adraffy/ens-normalize directly I get the dist folder. If I navigate to node_modules/ethers/node_modules/@adraffy/ens-normalise there is no dist folder.

If I copy the dist folder from node_modules/@adraffy/ens-normalise to the path listed above I get past this issue (and on to the next issue in my migration from v5 lol).

So, how do we force the @adraffy/ens-normalise within the ethers directory to get a dist folder and contents?

Code Snippet

No response

Contract ABI

No response

Errors

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/mattp/Documents/GitHub/crowsnest/node_modules/ethers/node_modules/@adraffy/ens-normalize/dist/index.mjs' imported from /Users/mattp/Documents/GitHub/crowsnest/node_modules/ethers/lib.esm/hash/namehash.js

Environment

node.js (v12 or newer)

Environment (Other)

No response

@omnus omnus added investigate Under investigation and may be a bug. v6 Issues regarding v6 labels May 30, 2023
@ricmoo
Copy link
Member

ricmoo commented May 30, 2023

Thanks. I am working to resolve this. :)

@omnus
Copy link
Author

omnus commented May 30, 2023

Thanks. I am working to resolve this. :)

Amazing, thank you!

@tompere
Copy link

tompere commented May 31, 2023

forcing ethers to use @adraffy/ens-normalize@1.9.2 as a direct dependency worked me (yarn "resolutions"), so I guess a quick dependency update is what we need on ethers side.

@ricmoo
Copy link
Member

ricmoo commented Jun 6, 2023

This should be fixed in v6.4.2. Can you try it out and let me know if you still have any problems?

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed investigate Under investigation and may be a bug. labels Jun 6, 2023
@ricmoo
Copy link
Member

ricmoo commented Jun 8, 2023

Closing now, but please re-open if it is still an issue.

Thanks! :)

@ricmoo ricmoo closed this as completed Jun 8, 2023
@warao-gil
Copy link

It works. thanks

@omnus
Copy link
Author

omnus commented Jun 13, 2023

This should be fixed in v6.4.2. Can you try it out and let me know if you still have any problems?

Sorry for the slow reply. Works for me! Thanks very much @ricmoo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6
Projects
None yet
Development

No branches or pull requests

4 participants