Use Numeric type for decimals parameter in FixedNumber.fromValue()

[SalamandraDevs]

Describe the Feature

The current function signature of FixedNumber.fromValue() is as follows:

FixedNumber.fromValue(value: BigNumberish, decimals?: number, format?: FixedFormat) ⇒ FixedNumber)

The returning numeric values in ethers are bigint, as far as I know, also the Numeric type in ethers is an union of bigint and number types. For that reason I consider that is better to change the type of decimals parameter from number to Numeric to allow bigint type also, letting the function signature as follows.

FixedNumber.fromValue(value: BigNumberish, decimals?: Numeric, format?: FixedFormat) ⇒ FixedNumber)

Code Example

// Currently you have to do this:

`const reserve0Fix = FixedNumber.fromValue(reserve0, Number(token0Decimals));`

// With the modification you could do this:

`const reserve0Fix = FixedNumber.fromValue(reserve0, token0Decimals);`

[ricmoo]

Yes! You are absolutely correct. It should be a Numeric. I’ll make that change in the next minor bump.

[ricmoo]

This has been added in v6.6.0. Try it out and let me know. :)