Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy/paste error? #561

Closed
cellog opened this issue Jul 18, 2019 · 2 comments
Closed

copy/paste error? #561

cellog opened this issue Jul 18, 2019 · 2 comments
Labels
documentation Documentation related issue.

Comments

@cellog
Copy link

cellog commented Jul 18, 2019

https://github.com/ethers-io/ethers.js/blob/ethers-v5-beta/packages/contracts/package.json#L4

@ricmoo
Copy link
Member

ricmoo commented Jul 18, 2019

Yes. Very much so. I’ll fix that today/tomorrow. I need to go through all those package.json and tsconfig.json files and double check them. :)

I also want to update their readme with some basics and link to the docs node.

@ricmoo ricmoo added the documentation Documentation related issue. label Jul 22, 2019
ricmoo added a commit that referenced this issue Aug 22, 2019
@ricmoo
Copy link
Member

ricmoo commented Aug 22, 2019

Fixed this along with several other copy/paste issues in the descriptions. Oddly enough, the errors package is deprecated and the logger package should be used instead. :p

I haven't published these libraries yet, since it is just a metadata update, and there is no urgency to reflect this in npm. They will all be updated in the next update-versions though.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue.
Projects
None yet
Development

No branches or pull requests

2 participants