Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixedNumber.isZero() #898

Closed
EvilJordan opened this issue Jun 19, 2020 · 3 comments
Closed

FixedNumber.isZero() #898

EvilJordan opened this issue Jun 19, 2020 · 3 comments
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@EvilJordan
Copy link

It would be awesome if FixedNumber.isZero() was a function!
At the moment, I'm doing this (maybe it's real dumb?):

let fixedNumber = FixedNumber.from("123", "fixed");
let bigNumber = BigNumber.from(fixedNumber);
if(bigNumber.isZero()) { ... }
@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. labels Jun 20, 2020
@ricmoo
Copy link
Member

ricmoo commented Jun 20, 2020

This should absolutely be added and I'll work on it first thing next week.

@ricmoo
Copy link
Member

ricmoo commented Jun 29, 2020

This should now be available in 5.0.3.

Try it out and let me know if you have any issues. :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jun 29, 2020
@EvilJordan
Copy link
Author

Works great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants