Fix typo on maxPriorityFeePerGas key override #3793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricmoo
added
bug
|
Thanks! I’ll get to this asap. |
ricmoo
added a commit
that referenced
this pull request
Feb 19, 2023
|
Fixed in v6.0.5. Thanks! :) |
|
Awesome ! Cheers 👍🏻 |
ricmoo
added
fixed/complete
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes
maxPriorityFeePerGasoverrides to never propagate into the transaction when populating it, and for example on Polygon it leads towards the well known issue as you are passing bothmaxFeePerGasandmaxPriorityFeePerGasbut the second one disappears.