Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic error in getSigner #3821

Closed
wants to merge 1 commit into from
Closed

Conversation

fvictorio
Copy link

Hopefully self-explaining.

This should also be tested, but I won't be able to do that, sorry.

This is a showstopper for Hardhat because we rely on getSigner a lot.

@ricmoo
Copy link
Member

ricmoo commented Feb 23, 2023

That’s definitely a bug. I’ll get to that right away.

Let me know if you need any assistance updating hardhat too.

@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. v6 Issues regarding v6 labels Feb 23, 2023
@fvictorio
Copy link
Author

I have a bunch of things I noticed while trying to upgrade, what would be the best way to share them? An issue (or multiple issues) here? Discord?

ricmoo added a commit that referenced this pull request Feb 23, 2023
@ricmoo
Copy link
Member

ricmoo commented Feb 23, 2023

The CI is running now, and I'll publish it once it passes (sans the timeouts that aren't really failures; still trying to figure out the best way to deal with those).

I was trying to find our old convo on Twitter the other day to coordinate, but couldn't find it. Message me on any platform (discord is fine), and we'll get something figured out. We can schedule a Zoom call sometime too if that helps.

The v6.1 will fix the missing exports; the docs generation now spits out warnings for missing exports, which helped identify them.

Feel free to open a mega-issue though, and I can break out anything into a new issues that is not already included in an existing minor-bump issue. Just to make sure we get everything. :)

@ricmoo
Copy link
Member

ricmoo commented Feb 23, 2023

Merged in v6.0.8. Let me know if there are any more issues.

Thanks! :)

@ricmoo ricmoo closed this Feb 23, 2023
@fvictorio fvictorio deleted the patch-2 branch February 23, 2023 12:00
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Mar 21, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants