-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use non-capturing group in getBytes regexp #4741
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good idea! I'll get this into the next patch release. Thanks! :) |
ricmoo
added
enhancement
New feature or improvement.
on-deck
This Enhancement or Bug is currently being worked on.
v6
Issues regarding v6
next-patch
Issues scheduled for the next arch release.
labels
May 29, 2024
ricmoo
added a commit
that referenced
this pull request
May 29, 2024
Added in v6.12.2. Let me know if you come across any other regex's that make sense to non-capture. ;) Thanks! |
ricmoo
added
fixed/complete
This Bug is fixed or Enhancement is complete and published.
and removed
on-deck
This Enhancement or Bug is currently being worked on.
labels
Jun 2, 2024
This was referenced Aug 1, 2024
This was referenced Aug 16, 2024
Open
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or improvement.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
next-patch
Issues scheduled for the next arch release.
v6
Issues regarding v6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing huge read request I encountered following error in my code:
With some insight from this post here I changed regexp to use non-capturing group, and that fixed my app.