This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
Ci race detector test adjustments #1200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 7, 2019 13:29
'chunksize' and 'processors' were unused; I did a cascading delete.
The following test failed with `-race` flag on Travis.
--- FAIL: TestCleanIndex (43.85s)
ldbstore_test.go:757: context deadline exceeded
As `-race` can increase the run time by 10x.
Alternative: we could just to increase the timeout for the
specific test. As currently the timeout is hardcoded and (strangely)
does not depend on the size of 'n'. That could be achieved by adding
a new function mputWithCustomTimeout(), but then we should keep
symmetry and add custom timeout for mget(), too. But I think the
method already has too many parameters and might be replaced by
the ongoing storage rewrite. So I won't do.
The following test failed with `-race` flag on Travis.
--- FAIL: TestNetworkID (9.04s)
networkid_test.go:77: Error setting up network: context deadline exceeded
As `-race` can increase the run time by 10x.
TestOverlaySim consistently failed with `-race` flag on Travis. My assumption was that we hit Travis' memory limitations. After decreasing the node count the test started to pass. Note: `-race` may increase memory usage by 5-10x === RUN TestOverlaySim panic: Could not startup node network for mocker goroutine 35 [running]: github.com/ethereum/go-ethereum/p2p/simulations.startStop(0xc0002a7000, 0xc0002a8b40, 0x10) /home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/simulations/mocker.go:66 +0x8a0 created by github.com/ethereum/go-ethereum/p2p/simulations.(*Server).StartMocker /home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/simulations/http.go:348 +0x260 FAIL github.com/ethereum/go-ethereum/swarm/network/simulations 2.788s
The following test failed with `-race` flag on Travis. As `-race` might
increase the execution time by 2-20x.
--- FAIL: TestFileRetrieval (62.45s)
snapshot_retrieval_test.go:61: context deadline exceeded
FAIL github.com/ethereum/go-ethereum/swarm/network/stream 240.794s
frncmx
changed the title
janos
approved these changes
Feb 7, 2019
nonsense
approved these changes
Feb 7, 2019
|
upstream ethereum/go-ethereum#19017 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-raceTestOverlaySimsimulations so that we won't run out of memory on Travisrelates to: #741