Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-2728-pm_getERC20TokenQuotes_endpoint #140

Merged
merged 4 commits into from
Sep 30, 2024
Merged

PRO-2728-pm_getERC20TokenQuotes_endpoint #140

merged 4 commits into from
Sep 30, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Added pm_getERC20TokenQuotes endpoint support

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Sep 30, 2024

PRO-2728 Arka: `pm_getERC20TokenQuotes` endpoint support

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2024 •
edited
Loading

Deploying arka with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4fd140b
Status:⚡️  Build in progress...

View logs

ch4r10t33r
ch4r10t33r approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please update the documentation on etherspot.fyi and document this new endpoint.

nikhilkumar1612
nikhilkumar1612 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@nikhilkumar1612 nikhilkumar1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vignesha22 vignesha22 merged commit 484d88f into master Sep 30, 2024
3 of 4 checks passed
@vignesha22 vignesha22 deleted the PRO-2728-pm_getERC20TokenQuotes_endpoint branch September 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilkumar1612 nikhilkumar1612 nikhilkumar1612 approved these changes

@kanthgithub kanthgithub kanthgithub approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@lbw33 lbw33 Awaiting requested review from lbw33

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vignesha22 @ch4r10t33r @kanthgithub @nikhilkumar1612